Loading...
cache_builder/BuilderConfig.cpp dyld-1284.13 dyld-1245.1
--- dyld/dyld-1284.13/cache_builder/BuilderConfig.cpp
+++ dyld/dyld-1245.1/cache_builder/BuilderConfig.cpp
@@ -25,7 +25,6 @@
 #include "BuilderConfig.h"
 #include "BuilderOptions.h"
 #include "CodeSigningTypes.h"
-#include "Platform.h"
 
 #include "dyld_cache_config.h"
 
@@ -33,8 +32,6 @@
 
 using namespace cache_builder;
 using dyld3::GradedArchs;
-
-using mach_o::Platform;
 
 //
 // MARK: --- cache_builder::Logger methods ---
@@ -96,17 +93,24 @@
         this->discontiguous.emplace();
 
         this->discontiguous->regionAlignment = 1_GB;
-        this->discontiguous->subCacheTextLimit = CacheVMSize(512_MB);
     } else {
         // Everyone else uses contiguous mappings
         this->contiguous.emplace();
         this->contiguous->regionPadding = CacheVMSize(32_MB);
-        this->contiguous->subCacheTextDataLimit = CacheVMSize(2_GB);
         this->contiguous->subCacheStubsLimit = CacheVMSize(110_MB);
-
-        // Note we have 2 padding regions in total in a given TEXT/DATA/AUTH/... region
-        // 1 between TEXT/DATA_CONST and DATA, then another from DATA to LINKEDIT.
-        this->contiguous->subCachePadding = this->contiguous->regionPadding + this->contiguous->regionPadding;
+    }
+
+    if ( (archName == "x86_64") || (archName == "x86_64h") ) {
+        this->subCacheTextLimit = CacheVMSize(512_MB);
+    } else {
+        // Note the 64MB is to give us just a little more space before making another
+        // sub cache file.  We want to make as few files as possible for things like page-tables
+        // The real constraint here is that TEXT+DATA must stay within 2GB for int32_t relative
+        // offsets in objc/swift metadata and in unwind info.  But also the __objc_opt section
+        // in libobjc needs to reach the __OBJC_RO in the read-only subcache.  That comes after
+        // data and as of writing leaves 150MB from its end until the 2GB mark.  So take 64MB from
+        // that 150MB and hope its ok for now.
+        this->subCacheTextLimit = CacheVMSize(1.5_GB + 64_MB);
     }
 
     struct CacheLayout
@@ -136,11 +140,6 @@
     } else if ( archName == "arm64_32" ) {
         layout.baseAddress = ARM64_32_SHARED_REGION_START;
         layout.cacheSize = 2_GB;
-
-        // The cache contents can't exceed 2GB, but use the space above it for the slide
-        if ( ARM64_32_SHARED_REGION_SIZE >= layout.cacheSize ) {
-            this->cacheFixedSlide = ARM64_32_SHARED_REGION_SIZE - layout.cacheSize;
-        }
     } else {
         assert("Unknown arch");
     }
@@ -206,14 +205,14 @@
 // MARK: --- cache_builder::CodeSign methods ---
 //
 
-static cache_builder::CodeSign::Mode platformCodeSigningDigestMode(Platform platform)
-{
-    if ( platform == Platform::watchOS )
+static cache_builder::CodeSign::Mode platformCodeSigningDigestMode(dyld3::Platform platform)
+{
+    if ( platform == dyld3::Platform::watchOS )
         return cache_builder::CodeSign::Mode::agile;
     return cache_builder::CodeSign::Mode::onlySHA256;
 }
 
-static uint32_t codeSigningPageSize(Platform platform, const GradedArchs& arch)
+static uint32_t codeSigningPageSize(dyld3::Platform platform, const GradedArchs& arch)
 {
     std::string_view archName = arch.name();
     if ( (archName == "arm64e") || (archName == "arm64_32") )
@@ -221,7 +220,7 @@
 
     // arm64 on iOS is new enough for 16k pages, as is arm64 on macOS (ie the simulator)
     if ( archName == "arm64") {
-        if ( platform.isSimulator() || (platform == Platform::iOS) )
+        if ( dyld3::MachOFile::isSimulatorPlatform(platform) || (platform == dyld3::Platform::iOS) )
             return CS_PAGE_SIZE_16K;
         return CS_PAGE_SIZE_4K;
     }