--- xnu/xnu-344.2/libkern/c++/OSSymbol.cpp
+++ xnu/xnu-201.5/libkern/c++/OSSymbol.cpp
@@ -21,7 +21,6 @@
  */
 /* IOSymbol.cpp created by gvdl on Fri 1998-11-17 */
 
-#include <string.h>
 #include <sys/cdefs.h>
 
 __BEGIN_DECLS
@@ -30,7 +29,6 @@
 
 #include <libkern/c++/OSSymbol.h>
 #include <libkern/c++/OSLib.h>
-#include <string.h>
 
 #define super OSString
 
@@ -93,9 +91,9 @@
     inline void closeGate() { mutex_lock(poolGate); };
     inline void openGate()  { mutex_unlock(poolGate); };
 
-    OSSymbol *findSymbol(const char *cString, OSSymbol ***replace) const;
+    OSSymbol *findSymbol(const char *cString) const;
     OSSymbol *insertSymbol(OSSymbol *sym);
-    void removeSymbol(OSSymbol *sym);
+    void removeSymbol(const char *cString);
 
     OSSymbolPoolState initHashState();
     OSSymbol *nextHashState(OSSymbolPoolState *stateP);
@@ -210,7 +208,7 @@
         insertSymbol(insert);
 }
 
-OSSymbol *OSSymbolPool::findSymbol(const char *cString, OSSymbol ***replace) const
+OSSymbol *OSSymbolPool::findSymbol(const char *cString) const
 {
     Bucket *thisBucket;
     unsigned int j, inLen, hash;
@@ -220,8 +218,6 @@
     thisBucket = &buckets[hash % nBuckets];
     j = thisBucket->count;
 
-    *replace = NULL;
-
     if (!j)
         return 0;
 
@@ -229,28 +225,19 @@
         probeSymbol = (OSSymbol *) thisBucket->symbolP;
 
         if (inLen == probeSymbol->length
-        &&  (strcmp(probeSymbol->string, cString) == 0)) {
-	    probeSymbol->retain();
-	    if (probeSymbol->getRetainCount() != 0xffff)
-		return probeSymbol;
-	    else
-		// replace this one
-		*replace = (OSSymbol **) &thisBucket->symbolP;
-        }
-	return 0;
+        &&  (strcmp(probeSymbol->string, cString) == 0)
+        &&  (probeSymbol->getRetainCount() >= 1))	// WRONG need when
+            return probeSymbol;
+        else
+            return 0;
     }
 
     for (list = thisBucket->symbolP; j--; list++) {
         probeSymbol = *list;
         if (inLen == probeSymbol->length
-        &&  (strcmp(probeSymbol->string, cString) == 0)) {
-	    probeSymbol->retain();
-	    if (probeSymbol->getRetainCount() != 0xffff)
-		return probeSymbol;
-	    else
-		// replace this one
-		*replace = list;
-	}
+        &&  (strcmp(probeSymbol->string, cString) == 0)
+        &&  (probeSymbol->getRetainCount() >= 1))	// WRONG need when
+            return probeSymbol;
     }
 
     return 0;
@@ -318,13 +305,13 @@
     return 0;
 }
 
-void OSSymbolPool::removeSymbol(OSSymbol *sym)
+void OSSymbolPool::removeSymbol(const char *cString)
 {
     Bucket *thisBucket;
     unsigned int j, inLen, hash;
     OSSymbol *probeSymbol, **list;
 
-    hashSymbol(sym->string, &hash, &inLen); inLen++;
+    hashSymbol(cString, &hash, &inLen); inLen++;
     thisBucket = &buckets[hash % nBuckets];
     j = thisBucket->count;
     list = thisBucket->symbolP;
@@ -335,7 +322,8 @@
     if (j == 1) {
         probeSymbol = (OSSymbol *) list;
 
-        if (probeSymbol == sym) {
+        if (inLen == probeSymbol->length
+        &&  strcmp(probeSymbol->string, cString) == 0) {
             thisBucket->symbolP = 0;
             count--;
             thisBucket->count--;
@@ -346,7 +334,8 @@
 
     if (j == 2) {
         probeSymbol = list[0];
-        if (probeSymbol == sym) {
+        if (inLen == probeSymbol->length
+        &&  strcmp(probeSymbol->string, cString) == 0) {
             thisBucket->symbolP = (OSSymbol **) list[1];
             kfree((vm_offset_t)list, 2 * sizeof(OSSymbol *));
 	    ACCUMSIZE(-(2 * sizeof(OSSymbol *)));
@@ -356,7 +345,8 @@
         }
 
         probeSymbol = list[1];
-        if (probeSymbol == sym) {
+        if (inLen == probeSymbol->length
+        &&  strcmp(probeSymbol->string, cString) == 0) {
             thisBucket->symbolP = (OSSymbol **) list[0];
             kfree((vm_offset_t)list, 2 * sizeof(OSSymbol *));
 	    ACCUMSIZE(-(2 * sizeof(OSSymbol *)));
@@ -369,7 +359,8 @@
 
     for (; j--; list++) {
         probeSymbol = *list;
-        if (probeSymbol == sym) {
+        if (inLen == probeSymbol->length
+        &&  strcmp(probeSymbol->string, cString) == 0) {
 
             list = (OSSymbol **)
                 kalloc((thisBucket->count-1) * sizeof(OSSymbol *));
@@ -439,19 +430,16 @@
 
 const OSSymbol *OSSymbol::withCString(const char *cString)
 {
-    OSSymbol **replace;
-
     pool->closeGate();
 
-    OSSymbol *newSymb = pool->findSymbol(cString, &replace);
-    if (!newSymb && (newSymb = new OSSymbol) ) {
-	if (newSymb->OSString::initWithCString(cString)) {
-	    if (replace)
-		*replace = newSymb;
-	    else
-		pool->insertSymbol(newSymb);
-	} else {
-	    newSymb->OSString::free();
+    OSSymbol *newSymb = pool->findSymbol(cString);
+    if (newSymb)
+        newSymb->retain();
+    else if ( (newSymb = new OSSymbol) ) {
+	if (newSymb->OSString::initWithCString(cString))
+	    pool->insertSymbol(newSymb);
+	else {
+	    newSymb->free();
 	    newSymb = 0;
 	}
     }
@@ -462,19 +450,16 @@
 
 const OSSymbol *OSSymbol::withCStringNoCopy(const char *cString)
 {
-    OSSymbol **replace;
-
     pool->closeGate();
 
-    OSSymbol *newSymb = pool->findSymbol(cString, &replace);
-    if (!newSymb && (newSymb = new OSSymbol) ) {
-	if (newSymb->OSString::initWithCStringNoCopy(cString)) {
-	    if (replace)
-		*replace = newSymb;
-	    else
-		pool->insertSymbol(newSymb);
-	} else {
-	    newSymb->OSString::free();
+    OSSymbol *newSymb = pool->findSymbol(cString);
+    if (newSymb)
+        newSymb->retain();
+    else if ( (newSymb = new OSSymbol) ) {
+	if (newSymb->OSString::initWithCStringNoCopy(cString))
+	    pool->insertSymbol(newSymb);
+	else {
+	    newSymb->free();
 	    newSymb = 0;
 	}
     }
@@ -506,7 +491,7 @@
 void OSSymbol::free()
 {
     pool->closeGate();
-    pool->removeSymbol(this);
+    pool->removeSymbol(string);
     pool->openGate();
     
     super::free();