Loading...
--- xnu/xnu-3248.50.21/libkern/c++/OSArray.cpp
+++ xnu/xnu-1699.24.8/libkern/c++/OSArray.cpp
@@ -33,7 +33,6 @@
#include <libkern/c++/OSDictionary.h>
#include <libkern/c++/OSSerialize.h>
#include <libkern/c++/OSLib.h>
-#include <libkern/OSDebug.h>
#define super OSCollection
@@ -47,23 +46,27 @@
OSMetaClassDefineReservedUnused(OSArray, 6);
OSMetaClassDefineReservedUnused(OSArray, 7);
+#if OSALLOCDEBUG
+extern "C" {
+ extern int debug_container_malloc_size;
+};
+#define ACCUMSIZE(s) do { debug_container_malloc_size += (s); } while(0)
+#else
+#define ACCUMSIZE(s)
+#endif
#define EXT_CAST(obj) \
reinterpret_cast<OSObject *>(const_cast<OSMetaClassBase *>(obj))
bool OSArray::initWithCapacity(unsigned int inCapacity)
{
- unsigned int size;
+ int size;
if (!super::init())
return false;
- // integer overflow check
- if (inCapacity > (UINT_MAX / sizeof(const OSMetaClassBase*)))
- return false;
-
size = sizeof(const OSMetaClassBase *) * inCapacity;
- array = (const OSMetaClassBase **) kalloc_container(size);
+ array = (const OSMetaClassBase **) kalloc(size);
if (!array)
return false;
@@ -72,7 +75,7 @@
capacityIncrement = (inCapacity)? inCapacity : 16;
bzero(array, size);
- OSCONTAINER_ACCUMSIZE(size);
+ ACCUMSIZE(size);
return true;
}
@@ -164,7 +167,7 @@
if (array) {
kfree(array, sizeof(const OSMetaClassBase *) * capacity);
- OSCONTAINER_ACCUMSIZE( -(sizeof(const OSMetaClassBase *) * capacity) );
+ ACCUMSIZE( -(sizeof(const OSMetaClassBase *) * capacity) );
}
super::free();
@@ -184,33 +187,27 @@
unsigned int OSArray::ensureCapacity(unsigned int newCapacity)
{
const OSMetaClassBase **newArray;
- unsigned int finalCapacity;
- unsigned int oldSize, newSize;
+ int oldSize, newSize;
if (newCapacity <= capacity)
return capacity;
// round up
- finalCapacity = (((newCapacity - 1) / capacityIncrement) + 1)
+ newCapacity = (((newCapacity - 1) / capacityIncrement) + 1)
* capacityIncrement;
-
- // integer overflow check
- if ((finalCapacity < newCapacity) || (finalCapacity > (UINT_MAX / sizeof(const OSMetaClassBase*))))
- return capacity;
-
- newSize = sizeof(const OSMetaClassBase *) * finalCapacity;
-
- newArray = (const OSMetaClassBase **) kalloc_container(newSize);
+ newSize = sizeof(const OSMetaClassBase *) * newCapacity;
+
+ newArray = (const OSMetaClassBase **) kalloc(newSize);
if (newArray) {
oldSize = sizeof(const OSMetaClassBase *) * capacity;
- OSCONTAINER_ACCUMSIZE(((size_t)newSize) - ((size_t)oldSize));
+ ACCUMSIZE(newSize - oldSize);
bcopy(array, newArray, oldSize);
bzero(&newArray[capacity], newSize - oldSize);
kfree(array, oldSize);
array = newArray;
- capacity = finalCapacity;
+ capacity = newCapacity;
}
return capacity;
@@ -402,8 +399,8 @@
if (!s->addXMLStartTag(this, "array")) return false;
- for (unsigned i = 0; i < count; i++) {
- if (array[i] == NULL || !array[i]->serialize(s)) return false;
+ for (unsigned i = 0; i < count; i++) {
+ if (!array[i]->serialize(s)) return false;
}
return s->addXMLEndTag("array");