Loading...
--- xnu/xnu-2422.100.13/libkern/c++/OSData.cpp
+++ xnu/xnu-3248.30.4/libkern/c++/OSData.cpp
@@ -49,38 +49,30 @@
#define EXTERNAL ((unsigned int) -1)
-#if OSALLOCDEBUG
-extern int debug_container_malloc_size;
-#define ACCUMSIZE(s) do { debug_container_malloc_size += (s); } while(0)
-#else
-#define ACCUMSIZE(s)
-#endif
-
-struct OSData::ExpansionData
-{
- DeallocFunction deallocFunction;
- bool disableSerialization;
-};
-
bool OSData::initWithCapacity(unsigned int inCapacity)
{
+ if (data)
+ {
+ OSCONTAINER_ACCUMSIZE(-((size_t)capacity));
+ if (!inCapacity || (capacity < inCapacity))
+ {
+ // clean out old data's storage if it isn't big enough
+ kfree(data, capacity);
+ data = 0;
+ capacity = 0;
+ }
+ }
+
if (!super::init())
return false;
- if (data && (!inCapacity || capacity < inCapacity) ) {
- // clean out old data's storage if it isn't big enough
- kfree(data, capacity);
- data = 0;
- ACCUMSIZE(-capacity);
- }
-
if (inCapacity && !data) {
- data = (void *) kalloc(inCapacity);
+ data = (void *) kalloc_container(inCapacity);
if (!data)
return false;
capacity = inCapacity;
- ACCUMSIZE(inCapacity);
- }
+ }
+ OSCONTAINER_ACCUMSIZE(capacity);
length = 0;
if (inCapacity < 16)
@@ -195,7 +187,7 @@
{
if (capacity != EXTERNAL && data && capacity) {
kfree(data, capacity);
- ACCUMSIZE( -capacity );
+ OSCONTAINER_ACCUMSIZE( -((size_t)capacity) );
} else if (capacity == EXTERNAL) {
DeallocFunction freemem = reserved ? reserved->deallocFunction : NULL;
if (freemem && data && length) {
@@ -224,24 +216,29 @@
unsigned int OSData::ensureCapacity(unsigned int newCapacity)
{
unsigned char * newData;
+ unsigned int finalCapacity;
if (newCapacity <= capacity)
return capacity;
- newCapacity = (((newCapacity - 1) / capacityIncrement) + 1)
+ finalCapacity = (((newCapacity - 1) / capacityIncrement) + 1)
* capacityIncrement;
- newData = (unsigned char *) kalloc(newCapacity);
-
+ // integer overflow check
+ if (finalCapacity < newCapacity)
+ return capacity;
+
+ newData = (unsigned char *) kalloc_container(finalCapacity);
+
if ( newData ) {
- bzero(newData + capacity, newCapacity - capacity);
+ bzero(newData + capacity, finalCapacity - capacity);
if (data) {
bcopy(data, newData, capacity);
kfree(data, capacity);
}
- ACCUMSIZE( newCapacity - capacity );
+ OSCONTAINER_ACCUMSIZE( ((size_t)finalCapacity) - ((size_t)capacity) );
data = (void *) newData;
- capacity = newCapacity;
+ capacity = finalCapacity;
}
return capacity;
@@ -446,7 +443,7 @@
{
if (!reserved)
{
- reserved = (typeof(reserved)) kalloc(sizeof(ExpansionData));
+ reserved = (typeof(reserved)) kalloc_container(sizeof(ExpansionData));
if (!reserved) return;
bzero(reserved, sizeof(ExpansionData));
}
@@ -457,7 +454,7 @@
{
if (!reserved)
{
- reserved = (typeof(reserved)) kalloc(sizeof(ExpansionData));
+ reserved = (typeof(reserved)) kalloc_container(sizeof(ExpansionData));
if (!reserved) return;
bzero(reserved, sizeof(ExpansionData));
}