Loading...
libkern/c++/OSSet.cpp xnu-1699.22.73 xnu-1228
--- xnu/xnu-1699.22.73/libkern/c++/OSSet.cpp
+++ xnu/xnu-1228/libkern/c++/OSSet.cpp
@@ -76,7 +76,6 @@
         return false;
 
     for ( unsigned int i = 0; i < inCount; i++ ) {
-// xx-review: no test here for failure of setObject()
         if (members->getCount() < inCapacity)
             setObject(inObjects[i]);
         else
@@ -196,36 +195,27 @@
 
 bool OSSet::setObject(const OSMetaClassBase *anObject)
 {
-    if (containsObject(anObject)) {
-        return false;
-    } else {
+    if (containsObject(anObject))
+        return false;
+    else {
         haveUpdated();
         return members->setObject(anObject);
     }
 }
 
-bool OSSet::merge(const OSArray * array)
-{
-    const OSMetaClassBase * anObject = 0;
-    bool                    result   = true;
-
-    for (int i = 0; (anObject = array->getObject(i)); i++) {
-
-       /* setObject() returns false if the object is already in the set,
-        * so we have to check beforehand here with containsObject().
-        */
-        if (containsObject(anObject)) {
-            continue;
-        }
-        if (!setObject(anObject)) {
-            result = false;
-        }
-    }
-
-    return result;
-}
-
-bool OSSet::merge(const OSSet * set)
+bool OSSet::merge(const OSArray *array)
+{
+    const OSMetaClassBase *anObject;
+    bool retVal = false;
+
+    for (int i = 0; (anObject = array->getObject(i)); i++)
+        if (setObject(anObject))
+            retVal = true;
+
+    return retVal;
+}
+
+bool OSSet::merge(const OSSet *set)
 {
     return merge(set->members);
 }