Loading...
--- xnu/xnu-1228/libkern/c++/OSSet.cpp
+++ xnu/xnu-1504.9.37/libkern/c++/OSSet.cpp
@@ -76,6 +76,7 @@
return false;
for ( unsigned int i = 0; i < inCount; i++ ) {
+// xx-review: no test here for failure of setObject()
if (members->getCount() < inCapacity)
setObject(inObjects[i]);
else
@@ -208,6 +209,8 @@
const OSMetaClassBase *anObject;
bool retVal = false;
+// xx-review: if any setObject fails due to memory allocation failure,
+// xx-review: this function should return false
for (int i = 0; (anObject = array->getObject(i)); i++)
if (setObject(anObject))
retVal = true;