Loading...
--- libmalloc/libmalloc-657.60.21/tests/zone_names.c
+++ libmalloc/libmalloc-521.120.7/tests/zone_names.c
@@ -15,6 +15,10 @@
 #include <stdlib.h>  // free()
 
 #include "../src/platform.h"  // CONFIG_NANOZONE
+
+T_GLOBAL_META(T_META_ENVVAR("MallocProbGuard=0"));
+// A local T_META_ENVVAR declaration will override all global ones so we have to
+// restate this on tests that use T_META_ENVVAR.
 
 static void
 check_zone_names(malloc_zone_t **zones, const char **names, uint32_t count)
@@ -36,15 +40,14 @@
 
 T_DECL(default_zone, "Zone names: default",
 		T_META_ENVVAR("MallocNanoZone=0"), T_META_ENVVAR("MallocProbGuard=0"),
-		T_META_TAG_XZONE, T_META_TAG_VM_PREFERRED)
+		T_META_TAG_XZONE)
 {
 	const char *names[] = {"DefaultMallocZone"};
 	check_default_zone_names(names, 1);
 }
 
 T_DECL(default_zone_and_nano, "Zone names: default + nano",
-		T_META_ENVVAR("MallocNanoZone=1"), T_META_ENVVAR("MallocProbGuard=0"),
-	    T_META_TAG_VM_PREFERRED)
+		T_META_ENVVAR("MallocNanoZone=1"), T_META_ENVVAR("MallocProbGuard=0"))
 {
 #if CONFIG_NANOZONE
 	const char *names[] = {"DefaultMallocZone", "MallocHelperZone"};
@@ -56,13 +59,13 @@
 
 T_DECL(default_zone_and_pgm, "Zone names: default + ProbGuard",
 		T_META_ENVVAR("MallocProbGuard=1"), T_META_ENVVAR("MallocNanoZone=0"),
-		T_META_TAG_XZONE, T_META_TAG_VM_PREFERRED)
+		T_META_TAG_XZONE)
 {
 	const char *names[] = {"ProbGuardMallocZone", "DefaultMallocZone"};
 	check_default_zone_names(names, 2);
 }
 
-T_DECL(zone_singletons, "Zone singletons", T_META_TAG_XZONE, T_META_TAG_VM_PREFERRED)
+T_DECL(zone_singletons, "Zone singletons", T_META_TAG_XZONE)
 {
 	malloc_zone_t *zones[] = {
 		malloc_default_zone(),
@@ -84,15 +87,14 @@
 	return zone;
 }
 
-T_DECL(virtual_zone0, "Ensure we return the virtual zone in place of zone 0", 	T_META_TAG_VM_PREFERRED)
+T_DECL(virtual_zone0, "Ensure we return the virtual zone in place of zone 0")
 {
 	malloc_zone_t *virtual_zone = malloc_default_zone();
 	T_EXPECT_NE(virtual_zone, malloc_zones[0], NULL);
 	T_EXPECT_EQ(call_malloc_zone_from_ptr(), virtual_zone, NULL);
 }
 
-T_DECL(zone_creation, "Zone creation",
-		T_META_ENVVAR("MallocProbGuard=0"), T_META_TAG_XZONE, T_META_TAG_VM_NOT_PREFERRED)
+T_DECL(zone_creation, "Zone creation", T_META_TAG_XZONE)
 {
 	T_EXPECT_NULL(malloc_create_zone(0, 0)->zone_name, "No name");
 }
@@ -115,14 +117,10 @@
 	const char *copy = zone_name;
 	malloc_set_zone_name(zone, NULL);
 	T_EXPECT_NULL(zone_name, "zone name set to NULL");
-	if (!malloc_engaged_secure_allocator()) {
-		// Xzone Malloc can mistakenly report tiny freed chunks as allocated if
-		// the chunk is madvised
-		T_EXPECT_EQ(malloc_size(copy), 0ul, "copy freed");
-	}
+	T_EXPECT_EQ(malloc_size(copy), 0ul, "copy freed");
 }
 
-T_DECL(malloc_set_zone_name, "malloc_set_zone_name", T_META_TAG_XZONE, T_META_TAG_VM_PREFERRED)
+T_DECL(malloc_set_zone_name, "malloc_set_zone_name", T_META_TAG_XZONE)
 {
 	malloc_zone_t *zones[] = {
 		malloc_default_zone(),
@@ -150,8 +148,7 @@
 		"Setting name of wrapper zone delegates to wrapped zone",
 		T_META_ENVVAR("MallocProbGuard=1"),
 		T_META_CHECK_LEAKS(false), // rdar://114740269
-		T_META_TAG_XZONE,
-	    T_META_TAG_VM_PREFERRED)
+		T_META_TAG_XZONE)
 {
 	malloc_zone_t *zone = malloc_zones[0];
 	malloc_zone_t *wrapped_zone = get_wrapped_zone(zone);