Loading...
--- libmalloc/libmalloc-657.60.21/src/magazine_medium.c
+++ libmalloc/libmalloc-646.0.13/src/magazine_medium.c
@@ -2433,17 +2433,16 @@
// The magazine is exhausted. A new region (heap) must be allocated to satisfy this call to malloc().
// The allocation, an mmap() system call, will be performed outside the magazine spin locks by the first
- // thread that suffers the exhaustion. That thread accquires the magazine_alloc_lock, then drops the
- // magazine lock to allow freeing threads to proceed. Allocating thrads that arrive later are excluded
- // from the critial section by the alloc lock. When those are unblocked, they succeed in the code above.
- //
- // Note that we need to trylock the alloc lock to avoid a deadlock, since we can't block on the alloc
- // lock while holding the magazine lock
- if (os_likely(_malloc_lock_trylock(&medium_mag_ptr->magazine_alloc_lock))) {
- // We got the alloc lock, so we are the thread that should allocate a new region
+ // thread that suffers the exhaustion. That thread sets "alloc_underway" and enters a critical section.
+ // Threads arriving here later are excluded from the critical section, yield the CPU, and then retry the
+ // allocation. After some time the magazine is resupplied, the original thread leaves with its allocation,
+ // and retry-ing threads succeed in the code just above.
+ if (!medium_mag_ptr->alloc_underway) {
void *fresh_region;
// time to create a new region (do this outside the magazine lock)
+ medium_mag_ptr->alloc_underway = TRUE;
+ OSMemoryBarrier();
SZONE_MAGAZINE_PTR_UNLOCK(medium_mag_ptr);
fresh_region = mvm_allocate_pages(MEDIUM_REGION_SIZE,
MEDIUM_BLOCKS_ALIGN,
@@ -2456,8 +2455,9 @@
fresh_region, MEDIUM_REGION_SIZE);
if (!fresh_region) { // out of memory!
+ medium_mag_ptr->alloc_underway = FALSE;
+ OSMemoryBarrier();
SZONE_MAGAZINE_PTR_UNLOCK(medium_mag_ptr);
- _malloc_lock_unlock(&medium_mag_ptr->magazine_alloc_lock);
return NULL;
}
@@ -2466,20 +2466,14 @@
mag_index, msize, fresh_region);
// we don't clear because this freshly allocated space is pristine
+ medium_mag_ptr->alloc_underway = FALSE;
+ OSMemoryBarrier();
SZONE_MAGAZINE_PTR_UNLOCK(medium_mag_ptr);
- _malloc_lock_unlock(&medium_mag_ptr->magazine_alloc_lock);
CHECK(szone, __PRETTY_FUNCTION__);
return ptr;
} else {
- // We failed to get the alloc lock, so someone else is allocating.
- // Drop the magazine lock...
SZONE_MAGAZINE_PTR_UNLOCK(medium_mag_ptr);
-
- // Wait for the other thread on the alloc lock
- _malloc_lock_lock(&medium_mag_ptr->magazine_alloc_lock);
- _malloc_lock_unlock(&medium_mag_ptr->magazine_alloc_lock);
-
- // Reacquire the magazine lock to go around the loop again
+ yield();
SZONE_MAGAZINE_PTR_LOCK(medium_mag_ptr);
}
}