Loading...
dyld3/PathOverrides.cpp dyld-733.6 dyld-625.13
--- dyld/dyld-733.6/dyld3/PathOverrides.cpp
+++ dyld/dyld-625.13/dyld3/PathOverrides.cpp
@@ -34,8 +34,6 @@
 #include <sys/errno.h>
 #include <unistd.h>
 
-#include <initializer_list>
-
 #include "PathOverrides.h"
 
 
@@ -68,7 +66,7 @@
 void PathOverrides::setEnvVars(const char* envp[], const MachOFile* mainExe, const char* mainExePath)
 {
     for (const char** p = envp; *p != NULL; p++) {
-        addEnvVar(*p, false);
+        addEnvVar(*p);
     }
     if ( mainExe != nullptr )
         setMainExecutable(mainExe, mainExePath);
@@ -80,7 +78,7 @@
     assert(mainExe->isMainExecutable());
     // process any LC_DYLD_ENVIRONMENT load commands in main executable
 	mainExe->forDyldEnv(^(const char* envVar, bool& stop) {
-        addEnvVar(envVar, true);
+        addEnvVar(envVar);
 	});
 }
 
@@ -92,11 +90,31 @@
 }
 #endif
 
-void PathOverrides::forEachInsertedDylib(void (^handler)(const char* dylibPath, bool &stop)) const
+uint32_t PathOverrides::envVarCount() const
+{
+    uint32_t count = 0;
+    if ( _dylibPathOverrides != nullptr )
+        ++count;
+    if ( _frameworkPathOverrides != nullptr )
+        ++count;
+    if ( _frameworkPathFallbacks != nullptr )
+        ++count;
+    if ( _dylibPathFallbacks != nullptr )
+        ++count;
+    if ( _insertedDylibs != nullptr )
+        ++count;
+    if ( _imageSuffix != nullptr )
+        ++count;
+    if ( _rootPath != nullptr )
+        ++count;
+    return count;
+}
+
+void PathOverrides::forEachInsertedDylib(void (^handler)(const char* dylibPath)) const
 {
     if ( _insertedDylibs != nullptr ) {
-        forEachInColonList(_insertedDylibs, nullptr, ^(const char* path, bool &stop) {
-            handler(path, stop);
+        forEachInColonList(_insertedDylibs, ^(const char* path, bool &stop) {
+            handler(path);
         });
     }
 }
@@ -113,25 +131,15 @@
     handler(buffer);
 }
 
-// Note, this method only returns variables set on the environment, not those from the load command
 void PathOverrides::forEachEnvVar(void (^handler)(const char* envVar)) const
 {
-    handleEnvVar("DYLD_LIBRARY_PATH",            _dylibPathOverridesEnv,        handler);
-    handleEnvVar("DYLD_FRAMEWORK_PATH",          _frameworkPathOverridesEnv,    handler);
-    handleEnvVar("DYLD_FALLBACK_FRAMEWORK_PATH", _frameworkPathFallbacksEnv,    handler);
-    handleEnvVar("DYLD_FALLBACK_LIBRARY_PATH",   _dylibPathFallbacksEnv,        handler);
-    handleEnvVar("DYLD_INSERT_LIBRARIES",        _insertedDylibs,               handler);
-    handleEnvVar("DYLD_IMAGE_SUFFIX",            _imageSuffix,                  handler);
-    handleEnvVar("DYLD_ROOT_PATH",               _rootPath,                     handler);
-}
-
-// Note, this method only returns variables set on the executable load command, not those from the environment
-void PathOverrides::forEachExecutableEnvVar(void (^handler)(const char* envVar)) const
-{
-    handleEnvVar("DYLD_LIBRARY_PATH",            _dylibPathOverridesExeLC,        handler);
-    handleEnvVar("DYLD_FRAMEWORK_PATH",          _frameworkPathOverridesExeLC,    handler);
-    handleEnvVar("DYLD_FALLBACK_FRAMEWORK_PATH", _frameworkPathFallbacksExeLC,    handler);
-    handleEnvVar("DYLD_FALLBACK_LIBRARY_PATH",   _dylibPathFallbacksExeLC,        handler);
+    handleEnvVar("DYLD_LIBRARY_PATH",            _dylibPathOverrides,      handler);
+    handleEnvVar("DYLD_FRAMEWORK_PATH",          _frameworkPathOverrides,  handler);
+    handleEnvVar("DYLD_FALLBACK_FRAMEWORK_PATH", _frameworkPathFallbacks,  handler);
+    handleEnvVar("DYLD_FALLBACK_LIBRARY_PATH",   _dylibPathFallbacks,      handler);
+    handleEnvVar("DYLD_INSERT_LIBRARIES",        _insertedDylibs,          handler);
+    handleEnvVar("DYLD_IMAGE_SUFFIX",            _imageSuffix,             handler);
+    handleEnvVar("DYLD_ROOT_PATH",               _rootPath,                handler);
 }
 
 const char* PathOverrides::addString(const char* str)
@@ -155,7 +163,7 @@
     var = addString(tmp);
 }
 
-void PathOverrides::addEnvVar(const char* keyEqualsValue, bool forExecutable)
+void PathOverrides::addEnvVar(const char* keyEqualsValue)
 {
     // We have to make a copy of the env vars because the dyld
     // semantics is that the env vars are only looked at once
@@ -163,16 +171,16 @@
     const char* equals = strchr(keyEqualsValue, '=');
     if ( equals != NULL ) {
         if ( strncmp(keyEqualsValue, "DYLD_LIBRARY_PATH", 17) == 0 ) {
-            setString(forExecutable ? _dylibPathOverridesExeLC : _dylibPathOverridesEnv, &keyEqualsValue[18]);
+            setString(_dylibPathOverrides, &keyEqualsValue[18]);
         }
         else if ( strncmp(keyEqualsValue, "DYLD_FRAMEWORK_PATH", 19) == 0 ) {
-            setString(forExecutable ? _frameworkPathOverridesExeLC : _frameworkPathOverridesEnv, &keyEqualsValue[20]);
+            setString(_frameworkPathOverrides, &keyEqualsValue[20]);
         }
         else if ( strncmp(keyEqualsValue, "DYLD_FALLBACK_FRAMEWORK_PATH", 28) == 0 ) {
-            setString(forExecutable ? _frameworkPathFallbacksExeLC : _frameworkPathFallbacksEnv, &keyEqualsValue[29]);
+            setString(_frameworkPathFallbacks, &keyEqualsValue[29]);
         }
         else if ( strncmp(keyEqualsValue, "DYLD_FALLBACK_LIBRARY_PATH", 26) == 0 ) {
-            setString(forExecutable ? _dylibPathFallbacksExeLC : _dylibPathFallbacksEnv, &keyEqualsValue[27]);
+            setString(_dylibPathFallbacks, &keyEqualsValue[27]);
         }
         else if ( strncmp(keyEqualsValue, "DYLD_INSERT_LIBRARIES", 21) == 0 ) {
             setString(_insertedDylibs, &keyEqualsValue[22]);
@@ -186,36 +194,30 @@
     }
 }
 
-void PathOverrides::forEachInColonList(const char* list1, const char* list2, void (^handler)(const char* path, bool& stop))
-{
-    for (const char* list : { list1, list2 }) {
-        if (list == nullptr)
+void PathOverrides::forEachInColonList(const char* list, void (^handler)(const char* path, bool& stop))
+{
+    char buffer[strlen(list)+1];
+    const char* t = list;
+    bool stop = false;
+    for (const char* s=list; *s != '\0'; ++s) {
+        if (*s != ':')
             continue;
-        char buffer[strlen(list)+1];
-        const char* t = list;
-        bool stop = false;
-        for (const char* s=list; *s != '\0'; ++s) {
-            if (*s != ':')
-                continue;
-            size_t len = s - t;
-            memcpy(buffer, t, len);
-            buffer[len] = '\0';
-            handler(buffer, stop);
-            if ( stop )
-                return;
-            t = s+1;
-        }
-        handler(t, stop);
-        if (stop)
+        size_t len = s - t;
+        memcpy(buffer, t, len);
+        buffer[len] = '\0';
+        handler(buffer, stop);
+        if ( stop )
             return;
-    }
+        t = s+1;
+    }
+    handler(t, stop);
 }
 
 void PathOverrides::forEachDylibFallback(Platform platform, void (^handler)(const char* fallbackDir, bool& stop)) const
 {
     __block bool stop = false;
-    if ( (_dylibPathFallbacksEnv != nullptr) || (_dylibPathFallbacksExeLC != nullptr) ) {
-        forEachInColonList(_dylibPathFallbacksEnv, _dylibPathFallbacksExeLC, ^(const char* pth, bool& innerStop) {
+    if ( _dylibPathFallbacks != nullptr ) {
+        forEachInColonList(_dylibPathFallbacks, ^(const char* pth, bool& innerStop) {
             handler(pth, innerStop);
             if ( innerStop )
                 stop = true;
@@ -230,7 +232,7 @@
                         handler("/usr/local/lib", stop);
                         if ( stop )
                             break;
-                        [[clang::fallthrough]];
+                        // fall thru
                     case FallbackPathMode::restricted:
                         handler("/usr/lib", stop);
                         break;
@@ -242,7 +244,6 @@
             case Platform::watchOS:
             case Platform::tvOS:
             case Platform::bridgeOS:
-            case Platform::driverKit:
             case Platform::unknown:
                 if ( _fallbackPathMode != FallbackPathMode::none ) {
                     handler("/usr/local/lib", stop);
@@ -250,7 +251,6 @@
                         break;
                 }
                 // fall into /usr/lib case
-                [[clang::fallthrough]];
             case Platform::iOSMac:
             case Platform::iOS_simulator:
             case Platform::watchOS_simulator:
@@ -265,8 +265,8 @@
 void PathOverrides::forEachFrameworkFallback(Platform platform, void (^handler)(const char* fallbackDir, bool& stop)) const
 {
     __block bool stop = false;
-    if ( (_frameworkPathFallbacksEnv != nullptr) || (_frameworkPathFallbacksExeLC != nullptr) ) {
-        forEachInColonList(_frameworkPathFallbacksEnv, _frameworkPathFallbacksExeLC, ^(const char* pth, bool& innerStop) {
+    if ( _frameworkPathFallbacks != nullptr ) {
+        forEachInColonList(_frameworkPathFallbacks, ^(const char* pth, bool& innerStop) {
             handler(pth, innerStop);
             if ( innerStop )
                 stop = true;
@@ -283,7 +283,6 @@
                             break;
                         // "/Network/Library/Frameworks"
                         // fall thru
-                        [[clang::fallthrough]];
                     case FallbackPathMode::restricted:
                         handler("/System/Library/Frameworks", stop);
                         break;
@@ -299,7 +298,6 @@
             case Platform::iOS_simulator:
             case Platform::watchOS_simulator:
             case Platform::tvOS_simulator:
-            case Platform::driverKit:
             case Platform::unknown:
                 if ( _fallbackPathMode != FallbackPathMode::none )
                     handler("/System/Library/Frameworks", stop);
@@ -340,13 +338,13 @@
     }
 }
 
-void PathOverrides::forEachImageSuffix(const char* path, bool isFallbackPath, bool pathIsInDyldCacheWhichCannotBeOverridden, bool& stop, void (^handler)(const char* possiblePath, bool isFallbackPath, bool& stop)) const
-{
-    if ( (_imageSuffix == nullptr) || pathIsInDyldCacheWhichCannotBeOverridden ) {
+void PathOverrides::forEachImageSuffix(const char* path, bool isFallbackPath, bool& stop, void (^handler)(const char* possiblePath, bool isFallbackPath, bool& stop)) const
+{
+    if ( _imageSuffix == nullptr ) {
         handler(path, isFallbackPath, stop);
     }
     else {
-        forEachInColonList(_imageSuffix, nullptr, ^(const char* suffix, bool& innerStop) {
+        forEachInColonList(_imageSuffix, ^(const char* suffix, bool& innerStop) {
             char npath[strlen(path)+strlen(suffix)+8];
             addSuffix(path, suffix, npath);
             handler(npath, isFallbackPath, innerStop);
@@ -358,65 +356,62 @@
     }
 }
 
-void PathOverrides::forEachPathVariant(const char* initialPath, bool pathIsInDyldCacheWhichCannotBeOverridden, void (^handler)(const char* possiblePath, bool isFallbackPath, bool& stop), Platform platform) const
+void PathOverrides::forEachPathVariant(const char* initialPath, void (^handler)(const char* possiblePath, bool isFallbackPath, bool& stop), Platform platform) const
 {
     __block bool stop = false;
 
-
-    if ( !pathIsInDyldCacheWhichCannotBeOverridden ) {
-        // check for overrides
-        const char* frameworkPartialPath = getFrameworkPartialPath(initialPath);
-        if ( frameworkPartialPath != nullptr ) {
-            const size_t frameworkPartialPathLen = strlen(frameworkPartialPath);
-            // look at each DYLD_FRAMEWORK_PATH directory
-            if ( (_frameworkPathOverridesEnv != nullptr) || (_frameworkPathOverridesExeLC != nullptr) ) {
-                forEachInColonList(_frameworkPathOverridesEnv, _frameworkPathOverridesExeLC, ^(const char* frDir, bool &innerStop) {
-                    char npath[strlen(frDir)+frameworkPartialPathLen+8];
-                    strcpy(npath, frDir);
-                    strcat(npath, "/");
-                    strcat(npath, frameworkPartialPath);
-                    forEachImageSuffix(npath, false, pathIsInDyldCacheWhichCannotBeOverridden, innerStop, handler);
-                    if ( innerStop )
-                        stop = true;
-                });
-            }
-        }
-        else {
-            const char* libraryLeafName = getLibraryLeafName(initialPath);
-            const size_t libraryLeafNameLen = strlen(libraryLeafName);
-            // look at each DYLD_LIBRARY_PATH directory
-            if ( (_dylibPathOverridesEnv != nullptr) || (_dylibPathOverridesExeLC != nullptr) ) {
-                forEachInColonList(_dylibPathOverridesEnv, _dylibPathOverridesExeLC, ^(const char* libDir, bool &innerStop) {
-                    char npath[strlen(libDir)+libraryLeafNameLen+8];
-                    strcpy(npath, libDir);
-                    strcat(npath, "/");
-                    strcat(npath, libraryLeafName);
-                    forEachImageSuffix(npath, false, pathIsInDyldCacheWhichCannotBeOverridden, innerStop, handler);
-                    if ( innerStop )
-                        stop = true;
-                });
-            }
-        }
-        if ( stop )
-            return;
-    }
-
-    // try original path
-    forEachImageSuffix(initialPath, false, pathIsInDyldCacheWhichCannotBeOverridden, stop, handler);
+    // check for overrides
+    const char* frameworkPartialPath = getFrameworkPartialPath(initialPath);
+    if ( frameworkPartialPath != nullptr ) {
+        const size_t frameworkPartialPathLen = strlen(frameworkPartialPath);
+        // look at each DYLD_FRAMEWORK_PATH directory
+        if ( _frameworkPathOverrides != nullptr ) {
+            forEachInColonList(_frameworkPathOverrides, ^(const char* frDir, bool &innerStop) {
+                char npath[strlen(frDir)+frameworkPartialPathLen+8];
+                strcpy(npath, frDir);
+                strcat(npath, "/");
+                strcat(npath, frameworkPartialPath);
+                forEachImageSuffix(npath, false, innerStop, handler);
+                if ( innerStop )
+                    stop = true;
+            });
+        }
+    }
+    else {
+        const char* libraryLeafName = getLibraryLeafName(initialPath);
+        const size_t libraryLeafNameLen = strlen(libraryLeafName);
+        // look at each DYLD_LIBRARY_PATH directory
+        if ( _dylibPathOverrides != nullptr ) {
+            forEachInColonList(_dylibPathOverrides, ^(const char* libDir, bool &innerStop) {
+                char npath[strlen(libDir)+libraryLeafNameLen+8];
+                strcpy(npath, libDir);
+                strcat(npath, "/");
+                strcat(npath, libraryLeafName);
+                forEachImageSuffix(npath, false, innerStop, handler);
+                if ( innerStop )
+                    stop = true;
+            });
+        }
+    }
     if ( stop )
         return;
 
+    // try original path
+    forEachImageSuffix(initialPath, false, stop, handler);
+    if ( stop )
+        return;
+
     // check fallback paths
-    if ( const char* frameworkPartialPath = getFrameworkPartialPath(initialPath) ) {
+    if ( frameworkPartialPath != nullptr ) {
         const size_t frameworkPartialPathLen = strlen(frameworkPartialPath);
         // look at each DYLD_FALLBACK_FRAMEWORK_PATH directory
-        bool usesDefaultFallbackPaths = (_frameworkPathFallbacksEnv == nullptr) && (_frameworkPathFallbacksExeLC == nullptr);
+        bool usesDefaultFallbackPaths = (_frameworkPathFallbacks == nullptr);
         forEachFrameworkFallback(platform, ^(const char* dir, bool& innerStop) {
             char npath[strlen(dir)+frameworkPartialPathLen+8];
             strcpy(npath, dir);
             strcat(npath, "/");
             strcat(npath, frameworkPartialPath);
-            forEachImageSuffix(npath, usesDefaultFallbackPaths, pathIsInDyldCacheWhichCannotBeOverridden, innerStop, handler);
+            forEachImageSuffix(npath, usesDefaultFallbackPaths, innerStop, handler);
             if ( innerStop )
                 stop = true;
         });
@@ -426,13 +421,13 @@
         const char* libraryLeafName = getLibraryLeafName(initialPath);
         const size_t libraryLeafNameLen = strlen(libraryLeafName);
         // look at each DYLD_FALLBACK_LIBRARY_PATH directory
-        bool usesDefaultFallbackPaths = (_dylibPathFallbacksEnv == nullptr) && (_dylibPathFallbacksExeLC == nullptr);
+        bool usesDefaultFallbackPaths = (_dylibPathFallbacks == nullptr);
         forEachDylibFallback(platform, ^(const char* dir, bool& innerStop) {
             char libpath[strlen(dir)+libraryLeafNameLen+8];
             strcpy(libpath, dir);
             strcat(libpath, "/");
             strcat(libpath, libraryLeafName);
-            forEachImageSuffix(libpath, usesDefaultFallbackPaths, pathIsInDyldCacheWhichCannotBeOverridden, innerStop, handler);
+            forEachImageSuffix(libpath, usesDefaultFallbackPaths, innerStop, handler);
             if ( innerStop )
                 stop = true;
         });