Loading...
--- dyld/dyld-551.3/dyld3/shared-cache/ImageProxy.cpp
+++ dyld/dyld-519.2.2/dyld3/shared-cache/ImageProxy.cpp
@@ -1212,7 +1212,7 @@
// add every dylib/bundle in "other: list to _images
uint32_t indexInGroup = 0;
for (const DyldSharedCache::MappedMachO& mapping : otherDylibsAndBundles) {
- ImageProxy* proxy = new ImageProxy(mapping, 1, indexInGroup++, true);
+ ImageProxy* proxy = new ImageProxy(mapping, 1, indexInGroup++, false);
groupProxy->_images.push_back(proxy);
groupProxy->_pathToProxy[mapping.runtimePath] = proxy;
}
@@ -1304,7 +1304,7 @@
ImageProxyGroup mainClosureGroupProxy(2, dyldCache, nullptr, otherOsDylibs, mainProgMapping.runtimePath, existingGroups, buildTimePrefixes,
emptyEnvVars, false, true, inodesAreSameAsRuntime);
- ImageProxy* mainProxy = new ImageProxy(mainProgMapping, 2, 0, true);
+ ImageProxy* mainProxy = new ImageProxy(mainProgMapping, 2, 0, false);
if ( mainProxy == nullptr ) {
diag.error("can't find slice matching dyld cache in %s", mainProgMapping.runtimePath.c_str());
return nullptr;
@@ -2149,10 +2149,7 @@
assert(interposeReplacement.isGroupImageTarget(replacementGroupNum, replacementIndexInGroup, replacementOffsetInImage));
assert(replacementGroupNum == 2);
assert(replacementIndexInGroup < (1 << 8));
- if ( replacementOffsetInImage >= 0xFFFFFFFFULL ) {
- diag.warning("bad interposing implementation in %s", _images[imageIndex]->runtimePath().c_str());
- return;
- }
+ assert(replacementOffsetInImage < 0xFFFFFFFFULL);
DyldCacheOverride cacheOverride;
cacheOverride.patchTableIndex = patchTableIndex;
cacheOverride.imageIndex = replacementIndexInGroup;
@@ -2228,10 +2225,7 @@
MachOParser::FoundSymbol foundInfo;
if ( weakDefParser.findExportedSymbol(weakDiag, entry.first.c_str(), nullptr, foundInfo, nullptr) ) {
assert(proxy->indexInGroup() < (1 << 8));
- if ( foundInfo.value >= (1ULL << 32) ) {
- diag.warning("bad weak symbol address in %s", proxy->runtimePath().c_str());
- return;
- }
+ assert(foundInfo.value < (1ULL << 32));
entry.second.imageIndex = proxy->indexInGroup();
entry.second.imageOffset = foundInfo.value;
}