Loading...
src/ImageLoader.cpp dyld-239.3 dyld-195.6
--- dyld/dyld-239.3/src/ImageLoader.cpp
+++ dyld/dyld-195.6/src/ImageLoader.cpp
@@ -24,7 +24,6 @@
 
 #define __STDC_LIMIT_MACROS
 #include <stdint.h>
-#include <stdlib.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <mach/mach.h>
@@ -65,35 +64,46 @@
 
 
 ImageLoader::ImageLoader(const char* path, unsigned int libCount)
-	: fPath(path), fRealPath(NULL), fDevice(0), fInode(0), fLastModified(0), 
-	fPathHash(0), fDlopenReferenceCount(0), fInitializerRecursiveLock(NULL), 
+	: fPath(path), fDevice(0), fInode(0), fLastModified(0), 
+	fPathHash(0), fDlopenReferenceCount(0), fStaticReferenceCount(0),
+	fDynamicReferenceCount(0), fDynamicReferences(NULL), fInitializerRecursiveLock(NULL), 
 	fDepth(0), fLoadOrder(fgLoadOrdinal++), fState(0), fLibraryCount(libCount), 
 	fAllLibraryChecksumsAndLoadAddressesMatch(false), fLeaveMapped(false), fNeverUnload(false),
 	fHideSymbols(false), fMatchByInstallName(false),
 	fInterposed(false), fRegisteredDOF(false), fAllLazyPointersBound(false), 
     fBeingRemoved(false), fAddFuncNotified(false),
-	fPathOwnedByImage(false), fIsReferencedDownward(false), 
-	fWeakSymbolsBound(false)
+	fPathOwnedByImage(false), fWeakSymbolsBound(false)
 {
 	if ( fPath != NULL )
 		fPathHash = hash(fPath);
-	if ( libCount > 512 )
-		dyld::throwf("too many dependent dylibs in %s", path);
 }
 
 
 void ImageLoader::deleteImage(ImageLoader* image)
 {
+	// this cannot be done in destructor because libImage() is implemented
+	// in a subclass
+	DependentLibraryInfo libraryInfos[image->libraryCount()]; 
+	image->doGetDependentLibraries(libraryInfos);
+	for(unsigned int i=0; i < image->libraryCount(); ++i) {
+		ImageLoader* lib = image->libImage(i);
+		if ( (lib != NULL) && ! libraryInfos[i].upward )
+			lib->fStaticReferenceCount--;
+	}
 	delete image;
 }
 
 
 ImageLoader::~ImageLoader()
 {
-	if ( fRealPath != NULL ) 
-		delete [] fRealPath;
 	if ( fPathOwnedByImage && (fPath != NULL) ) 
 		delete [] fPath;
+	if ( fDynamicReferences != NULL ) {
+		for (std::vector<const ImageLoader*>::iterator it = fDynamicReferences->begin(); it != fDynamicReferences->end(); ++it ) {
+			const_cast<ImageLoader*>(*it)->fDynamicReferenceCount--;
+		}
+		delete fDynamicReferences;
+	}
 }
 
 void ImageLoader::setFileInfo(dev_t device, ino_t inode, time_t modDate)
@@ -107,6 +117,27 @@
 {
 	fState = dyld_image_state_mapped;
 	context.notifySingle(dyld_image_state_mapped, this);  // note: can throw exception
+}
+
+void ImageLoader::addDynamicReference(const ImageLoader* target)
+{
+	bool alreadyInVector = false;
+	if ( fDynamicReferences == NULL ) {
+		fDynamicReferences = new std::vector<const ImageLoader*>();
+	}
+	else {
+		for (std::vector<const ImageLoader*>::iterator it = fDynamicReferences->begin(); it != fDynamicReferences->end(); ++it ) {
+			if ( *it == target ) {
+				alreadyInVector = true;
+				break;
+			}
+		}
+	}
+	if ( ! alreadyInVector ) {	
+		fDynamicReferences->push_back(target);
+		const_cast<ImageLoader*>(target)->fDynamicReferenceCount++;
+	}
+	//dyld::log("dyld: addDynamicReference() from %s to %s, fDynamicReferences->size()=%lu\n", this->getPath(), target->getPath(), fDynamicReferences->size());
 }
 
 int ImageLoader::compare(const ImageLoader* right) const
@@ -135,7 +166,6 @@
 	strcpy((char*)fPath, path);
 	fPathOwnedByImage = true;  // delete fPath when this image is destructed
 	fPathHash = hash(fPath);
-	fRealPath = NULL;
 }
 
 void ImageLoader::setPathUnowned(const char* path)
@@ -146,21 +176,6 @@
 	fPath = path;
 	fPathOwnedByImage = false;  
 	fPathHash = hash(fPath);
-}
-
-void ImageLoader::setPaths(const char* path, const char* realPath)
-{
-	this->setPath(path);
-	fRealPath = new char[strlen(realPath)+1];
-	strcpy((char*)fRealPath, realPath);
-}
-
-const char* ImageLoader::getRealPath() const 
-{ 
-	if ( fRealPath != NULL ) 
-		return fRealPath;
-	else
-		return fPath; 
 }
 
 
@@ -228,6 +243,8 @@
 
 bool ImageLoader::containsAddress(const void* addr) const
 {
+	if ( ! this->isLinked() )
+		return false;
 	for(unsigned int i=0, e=segmentCount(); i < e; ++i) {
 		const uint8_t* start = (const uint8_t*)segActualLoadAddress(i);
 		const uint8_t* end = (const uint8_t*)segActualEndAddress(i);
@@ -270,16 +287,6 @@
 }
 
 
-
-bool ImageLoader::dependsOn(ImageLoader* image) {
-	for(unsigned int i=0; i < libraryCount(); ++i) {
-		if ( libImage(i) == image )
-			return true;
-	}
-	return false;
-}
-
-
 static bool notInImgageList(const ImageLoader* image, const ImageLoader** dsiStart, const ImageLoader** dsiCur)
 {
 	for (const ImageLoader** p = dsiStart; p < dsiCur; ++p)
@@ -294,6 +301,7 @@
 			const ImageLoader** dsiStart, const ImageLoader**& dsiCur, const ImageLoader** dsiEnd, const ImageLoader** foundIn) const
 {
 	const ImageLoader::Symbol* sym;
+	
 	// search self
 	if ( notInImgageList(this, dsiStart, dsiCur) ) {
 		sym = this->findExportedSymbol(name, false, foundIn);
@@ -351,9 +359,9 @@
 		this->recursiveApplyInterposing(context);
 }
 
-void ImageLoader::link(const LinkContext& context, bool forceLazysBound, bool preflightOnly, bool neverUnload, const RPathChain& loaderRPaths)
-{
-	//dyld::log("ImageLoader::link(%s) refCount=%d, neverUnload=%d\n", this->getPath(), fDlopenReferenceCount, fNeverUnload);
+void ImageLoader::link(const LinkContext& context, bool forceLazysBound, bool preflightOnly, const RPathChain& loaderRPaths)
+{
+	//dyld::log("ImageLoader::link(%s) refCount=%d, neverUnload=%d\n", this->getPath(), fStaticReferenceCount, fNeverUnload);
 	
 	// clear error strings
 	(*context.setErrorStrings)(dyld_error_kind_none, NULL, NULL, NULL);
@@ -375,11 +383,10 @@
 	context.notifyBatch(dyld_image_state_rebased);
 	
 	uint64_t t3 = mach_absolute_time();
- 	this->recursiveBind(context, forceLazysBound, neverUnload);
+ 	this->recursiveBind(context, forceLazysBound);
 
 	uint64_t t4 = mach_absolute_time();
-	if ( !context.linkingMainExecutable )
-		this->weakBind(context);
+	this->weakBind(context);
 	uint64_t t5 = mach_absolute_time();	
 
 	context.notifyBatch(dyld_image_state_bound);
@@ -411,7 +418,8 @@
 
 void ImageLoader::printReferenceCounts()
 {
-	dyld::log("      dlopen=%d for %s\n", fDlopenReferenceCount, getPath() );
+	dyld::log("      dlopen=%d, static=%d, dynamic=%d for %s\n", 
+				fDlopenReferenceCount, fStaticReferenceCount, fDynamicReferenceCount, getPath() );
 }
 
 
@@ -460,29 +468,6 @@
 }
 
 
-void ImageLoader::markedUsedRecursive(const std::vector<DynamicReference>& dynamicReferences)
-{
-	// already visited here
-	if ( fMarkedInUse )
-		return;
-	fMarkedInUse = true;
-	
-	// clear mark on all statically dependent dylibs
-	for(unsigned int i=0; i < libraryCount(); ++i) {
-		ImageLoader* dependentImage = libImage(i);
-		if ( dependentImage != NULL ) {
-			dependentImage->markedUsedRecursive(dynamicReferences);
-		}
-	}
-	
-	// clear mark on all dynamically dependent dylibs
-	for (std::vector<ImageLoader::DynamicReference>::const_iterator it=dynamicReferences.begin(); it != dynamicReferences.end(); ++it) {
-		if ( it->from == this )
-			it->to->markedUsedRecursive(dynamicReferences);
-	}
-	
-}
-
 unsigned int ImageLoader::recursiveUpdateDepth(unsigned int maxDepth)
 {
 	// the purpose of this phase is to make the images sortable such that 
@@ -496,7 +481,7 @@
 		unsigned int minDependentDepth = maxDepth;
 		for(unsigned int i=0; i < libraryCount(); ++i) {
 			ImageLoader* dependentImage = libImage(i);
-			if ( (dependentImage != NULL) && !libIsUpward(i) ) {
+			if ( dependentImage != NULL ) {
 				unsigned int d = dependentImage->recursiveUpdateDepth(maxDepth);
 				if ( d < minDependentDepth )
 					minDependentDepth = d;
@@ -553,11 +538,8 @@
 				}
 				if ( fNeverUnload )
 					dependentLib->setNeverUnload();
-				if ( requiredLibInfo.upward ) {
-				}
-				else { 
-					dependentLib->fIsReferencedDownward = true;
-				}
+				if ( ! requiredLibInfo.upward )
+					dependentLib->fStaticReferenceCount += 1;
 				LibraryInfo actualInfo = dependentLib->doGetLibraryInfo();
 				depLibReRequired = requiredLibInfo.required;
 				depLibCheckSumsMatch = ( actualInfo.checksum == requiredLibInfo.info.checksum );
@@ -567,8 +549,7 @@
 					depLibReExported = dependentLib->isSubframeworkOf(context, this) || this->hasSubLibrary(context, dependentLib);
 				}
 				// check found library version is compatible
-				// <rdar://problem/89200806> 0xFFFFFFFF is wildcard that matches any version
-				if ( (requiredLibInfo.info.minVersion != 0xFFFFFFFF) && (actualInfo.minVersion < requiredLibInfo.info.minVersion) ) {
+				if ( actualInfo.minVersion < requiredLibInfo.info.minVersion ) {
 					// record values for possible use by CrashReporter or Finder
 					dyld::throwf("Incompatible library version: %s requires version %d.%d.%d or later, but %s provides version %d.%d.%d",
 							this->getShortName(), requiredLibInfo.info.minVersion >> 16, (requiredLibInfo.info.minVersion >> 8) & 0xff, requiredLibInfo.info.minVersion & 0xff,
@@ -601,7 +582,7 @@
 						(*context.setErrorStrings)(dyld_error_kind_dylib_wrong_arch, this->getPath(), requiredLibInfo.name, NULL);
 					else
 						(*context.setErrorStrings)(dyld_error_kind_dylib_missing, this->getPath(), requiredLibInfo.name, NULL);
-					dyld::throwf("Library not loaded: %s\n  Referenced from: %s\n  Reason: %s", requiredLibInfo.name, this->getRealPath(), msg);
+					dyld::throwf("Library not loaded: %s\n  Referenced from: %s\n  Reason: %s", requiredLibInfo.name, this->getPath(), msg);
 				}
 				// ok if weak library not found
 				dependentLib = NULL;
@@ -695,7 +676,7 @@
 
 
 
-void ImageLoader::recursiveBind(const LinkContext& context, bool forceLazysBound, bool neverUnload)
+void ImageLoader::recursiveBind(const LinkContext& context, bool forceLazysBound)
 {
 	// Normally just non-lazy pointers are bound immediately.
 	// The exceptions are:
@@ -710,16 +691,13 @@
 			for(unsigned int i=0; i < libraryCount(); ++i) {
 				ImageLoader* dependentImage = libImage(i);
 				if ( dependentImage != NULL )
-					dependentImage->recursiveBind(context, forceLazysBound, neverUnload);
+					dependentImage->recursiveBind(context, forceLazysBound);
 			}
 			// bind this image
 			this->doBind(context, forceLazysBound);	
 			// mark if lazys are also bound
 			if ( forceLazysBound || this->usablePrebinding(context) )
 				fAllLazyPointersBound = true;
-			// mark as never-unload if requested
-			if ( neverUnload )
-				this->setNeverUnload();
 				
 			context.notifySingle(dyld_image_state_bound, this);
 		}
@@ -736,7 +714,6 @@
 {
 	if ( context.verboseWeakBind )
 		dyld::log("dyld: weak bind start:\n");
-	uint64_t t1 = mach_absolute_time();
 	// get set of ImageLoaders that participate in coalecsing
 	ImageLoader* imagesNeedingCoalescing[fgImagesRequiringCoalescing];
 	int count = context.getCoalescedImages(imagesNeedingCoalescing);
@@ -842,9 +819,6 @@
 			imagesNeedingCoalescing[i]->fWeakSymbolsBound = true;
 		}
 	}
-	uint64_t t2 = mach_absolute_time();
-	fgTotalWeakBindTime += t2  - t1;
-	
 	if ( context.verboseWeakBind )
 		dyld::log("dyld: weak bind end\n");
 }
@@ -867,19 +841,6 @@
 	}
 }
 
-void ImageLoader::setNeverUnloadRecursive() {
-	if ( ! fNeverUnload ) {
-		// break cycles
-		fNeverUnload = true;
-		
-		// gather lower level libraries first
-		for(unsigned int i=0; i < libraryCount(); ++i) {
-			ImageLoader* dependentImage = libImage(i);
-			if ( dependentImage != NULL )
-				dependentImage->setNeverUnloadRecursive();
-		}
-	}
-}
 
 void ImageLoader::recursiveSpinLock(recursive_lock& rlock)
 {
@@ -911,25 +872,20 @@
 		// break cycles
 		fState = dyld_image_state_dependents_initialized-1;
 		try {
-			bool hasUpwards = false;
 			// initialize lower level libraries first
 			for(unsigned int i=0; i < libraryCount(); ++i) {
 				ImageLoader* dependentImage = libImage(i);
-				if ( dependentImage != NULL ) {
-					// don't try to initialize stuff "above" me
-					bool isUpward = libIsUpward(i);
-					if ( (dependentImage->fDepth >= fDepth) && !isUpward ) {
-						dependentImage->recursiveInitialization(context, this_thread, timingInfo);
-					}
-					hasUpwards |= isUpward;
-                }
+				if ( dependentImage != NULL )
+				// don't try to initialize stuff "above" me
+				if ( (dependentImage != NULL) && (dependentImage->fDepth >= fDepth) && !libIsUpward(i) )
+					dependentImage->recursiveInitialization(context, this_thread, timingInfo);
 			}
 			
 			// record termination order
 			if ( this->needsTermination() )
 				context.terminationRecorder(this);
 			
-			// let objc know we are about to initialize this image
+			// let objc know we are about to initalize this image
 			uint64_t t1 = mach_absolute_time();
 			fState = dyld_image_state_dependents_initialized;
 			oldState = fState;
@@ -937,20 +893,8 @@
 			
 			// initialize this image
 			bool hasInitializers = this->doInitialization(context);
-
-			// <rdar://problem/10491874> initialize any upward depedencies
-			if ( hasUpwards ) {
-				for(unsigned int i=0; i < libraryCount(); ++i) {
-					ImageLoader* dependentImage = libImage(i);
-					// <rdar://problem/10643239> ObjC CG hang
-					// only init upward lib here if lib is not downwardly referenced somewhere 
-					if ( (dependentImage != NULL) && libIsUpward(i) && !dependentImage->isReferencedDownward() ) {
-						dependentImage->recursiveInitialization(context, this_thread, timingInfo);
-					}
-				}
-			}
-            
-			// let anyone know we finished initializing this image
+			
+			// let anyone know we finished initalizing this image
 			fState = dyld_image_state_initialized;
 			oldState = fState;
 			context.notifySingle(dyld_image_state_initialized, this);
@@ -1091,8 +1035,5 @@
 }
 
 
-VECTOR_NEVER_DESTRUCTED_IMPL(ImageLoader::InterposeTuple);
-VECTOR_NEVER_DESTRUCTED_IMPL(ImagePair);
-
-
-
+
+