Loading...
libdyld/utils.cpp dyld-1284.13 dyld-1235.2
--- dyld/dyld-1284.13/libdyld/utils.cpp
+++ dyld/dyld-1235.2/libdyld/utils.cpp
@@ -38,7 +38,6 @@
 #include "DyldDelegates.h"
 
 // mach_o
-#include "Architecture.h"
 #include "Header.h"
 #include "Image.h"
 #include "Error.h"
@@ -49,16 +48,15 @@
 using dyld3::MachOFile;
 using dyld3::FatFile;
 using dyld3::GradedArchs;
+using dyld3::Platform;
 
 using mach_o::Header;
 using mach_o::Image;
 using mach_o::Error;
 using mach_o::Version32;
-using mach_o::Version64;
 using mach_o::LinkedDylibAttributes;
 using mach_o::Fixup;
 using mach_o::Symbol;
-using mach_o::Platform;
 
 // used by unit tests
 __attribute__((visibility("hidden")))
@@ -72,23 +70,14 @@
 
 bool macho_cpu_type_for_arch_name(const char* archName, cpu_type_t* type, cpu_subtype_t* subtype)
 {
-    mach_o::Architecture arch = mach_o::Architecture::byName(archName);
-    if ( arch == mach_o::Architecture::invalid )
-        return false;
-    
-    *type = arch.cpuType();
-    *subtype = arch.cpuSubtype();
-    return true;
+    return MachOFile::cpuTypeFromArchName(archName, type, subtype);
 }
 
 const char* macho_arch_name_for_cpu_type(cpu_type_t type, cpu_subtype_t subtype)
 {
-    const char* result = mach_o::Architecture(type, subtype).name();
+    const char* result = MachOFile::archName(type, subtype);
     if ( strcmp(result, "unknown") == 0 )
         return nullptr;
-    // Strip any suffix that further specifies the exact arm64e type (.old, .kernel, etc).
-    if ( std::string_view(result).starts_with("arm64e") )
-        return "arm64e";
     return result;
 }
 
@@ -164,13 +153,13 @@
     return result;
 }
 
-static bool launchableOnCurrentPlatform(const Header* mh)
+static bool launchableOnCurrentPlatform(const MachOFile* mf)
 {
 #if TARGET_OS_OSX
     // macOS is special and can launch macOS, catalyst, and iOS apps
-    return ( mh->builtForPlatform(Platform::macOS) || mh->builtForPlatform(Platform::macCatalyst) || mh->builtForPlatform(Platform::iOS) );
+    return ( mf->builtForPlatform(Platform::macOS) || mf->builtForPlatform(Platform::iOSMac) || mf->builtForPlatform(Platform::iOS) );
 #else
-    return mh->builtForPlatform(Platform::current());
+    return mf->builtForPlatform(MachOFile::currentPlatform());
 #endif
 }
 
@@ -194,18 +183,18 @@
         __block uint64_t sliceOffset = 0;
         __block uint64_t sliceLen    = 0;
         ff->forEachSlice(diag, statbuf.st_size, ^(uint32_t sliceCpuType, uint32_t sliceCpuSubType, const void* sliceStart, uint64_t sliceSize, bool& stop) {
-            if ( const Header* mh = Header::isMachO({(const uint8_t*)sliceStart, (size_t)sliceSize}) ) {
-                if ( mh->isMainExecutable() ) {
-                    int sliceGrade = launchArchs.grade(mh->arch().cpuType(), mh->arch().cpuSubtype(), isOSBinary);
-                    if ( (sliceGrade > bestGrade) && launchableOnCurrentPlatform(mh) ) {
+            if ( const MachOFile* mf = MachOFile::isMachO(sliceStart) ) {
+                if ( mf->filetype == MH_EXECUTE ) {
+                    int sliceGrade = launchArchs.grade(mf->cputype, mf->cpusubtype, isOSBinary);
+                    if ( (sliceGrade > bestGrade) && launchableOnCurrentPlatform(mf) ) {
                         sliceOffset = (char*)sliceStart - (char*)mappedFile;
                         sliceLen    = sliceSize;
                         bestGrade   = sliceGrade;
                     }
                 }
                 else {
-                    int sliceGrade = dylibArchs.grade(mh->arch().cpuType(), mh->arch().cpuSubtype(), isOSBinary);
-                    if ( (sliceGrade > bestGrade) && mh->loadableIntoProcess(platform, "") ) {
+                    int sliceGrade = dylibArchs.grade(mf->cputype, mf->cpusubtype, isOSBinary);
+                    if ( (sliceGrade > bestGrade) && mf->loadableIntoProcess(platform, "") ) {
                         sliceOffset = (char*)sliceStart - (char*)mappedFile;
                         sliceLen    = sliceSize;
                         bestGrade   = sliceGrade;
@@ -223,16 +212,16 @@
         else
             result = EBADARCH;
     }
-    else if ( const Header* mh = Header::isMachO({(const uint8_t*)mappedFile, (size_t)statbuf.st_size}) ) {
-        if ( mh->isMainExecutable() && (launchArchs.grade(mh->arch().cpuType(), mh->arch().cpuSubtype(), isOSBinary) != 0) && launchableOnCurrentPlatform(mh) )  {
+    else if ( const MachOFile* mf = MachOFile::isMachO(mappedFile) ) {
+        if ( (mf->filetype == MH_EXECUTE) && (launchArchs.grade(mf->cputype, mf->cpusubtype, isOSBinary) != 0) && launchableOnCurrentPlatform(mf) )  {
             // the "best" of a main executable must pass grading and be a launchable
             if ( bestSlice )
-                bestSlice((const mach_header*)mh, 0, (size_t)statbuf.st_size);
-        }
-        else if ( (dylibArchs.grade(mh->arch().cpuType(), mh->arch().cpuSubtype(), isOSBinary) != 0) && mh->loadableIntoProcess(platform, "") ) {
+                bestSlice(mf, 0, (size_t)statbuf.st_size);
+        }
+        else if ( (dylibArchs.grade(mf->cputype, mf->cpusubtype, isOSBinary) != 0) && mf->loadableIntoProcess(platform, "") ) {
             // the "best" of a dylib/bundle must pass grading and match the platform of the current process
             if ( bestSlice )
-                bestSlice((const mach_header*)mh, 0, (size_t)statbuf.st_size);
+                bestSlice(mf, 0, (size_t)statbuf.st_size);
         }
         else {
             result = EBADARCH;
@@ -267,7 +256,7 @@
     if ( stripPointer(p) != p )
        keysOff = false;
 #endif
-    const Platform     platform    = Platform::current();
+    const Platform     platform    = MachOFile::currentPlatform();
     const GradedArchs* launchArchs = &GradedArchs::launchCurrentOS();
     const GradedArchs* dylibArchs  = &GradedArchs::forCurrentOS(keysOff, false);
 #if TARGET_OS_SIMULATOR
@@ -286,17 +275,15 @@
 ///
 const char* _Nullable macho_dylib_install_name(const struct mach_header* _Nonnull mh) DYLD_EXCLAVEKIT_UNAVAILABLE
 {
-    const Header* hdr = (const Header*)mh;
-    if ( hdr->hasMachOMagic() )
-        return hdr->installName();
+    if ( const MachOFile* mf = MachOFile::isMachO(mh) )
+        return mf->installName();
 
     return nullptr;
 }
 
 static void iterateDependencies(const Image& image, void (^_Nonnull callback)(const char* _Nonnull loadPath, const char* _Nonnull attributes, bool* _Nonnull stop) )
 {
-    image.header()->forEachLinkedDylib(^(const char* loadPath, LinkedDylibAttributes kind, Version32 compatVersion, Version32 curVersion, 
-                                         bool synthesizedLink, bool& stop) {
+    image.header()->forEachLinkedDylib(^(const char* loadPath, LinkedDylibAttributes kind, Version32 compatVersion, Version32 curVersion, bool& stop) {
         char attrBuf[64];
         kind.toString(attrBuf);
         callback(loadPath, attrBuf, &stop);
@@ -443,19 +430,4 @@
     }
     return 0;
 }
-
-bool macho_source_version(const struct mach_header* _Nonnull mh, uint64_t* _Nonnull version)
-{
-    Header* header = (Header*)mh;
-    if ( !header->hasMachOMagic() )
-        return false;
-    
-    Version64 v;
-    if ( !header->sourceVersion(v) )
-        return false;
-    
-    *version = v.value();
-    return true;
-}
-
 #endif // !TARGET_OS_EXCLAVEKIT