Loading...
common/Diagnostics.cpp dyld-1042.1 dyld-955
--- dyld/dyld-1042.1/common/Diagnostics.cpp
+++ dyld/dyld-955/common/Diagnostics.cpp
@@ -51,19 +51,19 @@
 
 #include "Diagnostics.h"
 
-#if BUILDING_CACHE_BUILDER || BUILDING_UNIT_TESTS || BUILDING_CACHE_BUILDER_UNIT_TESTS
+#if BUILDING_CACHE_BUILDER
   #include <dispatch/dispatch.h>
   dispatch_queue_t sWarningQueue = dispatch_queue_create("com.apple.dyld.cache-builder.warnings", NULL);
 #endif
 
 Diagnostics::Diagnostics(bool verbose)
-#if BUILDING_CACHE_BUILDER || BUILDING_UNIT_TESTS || BUILDING_CACHE_BUILDER_UNIT_TESTS
+#if BUILDING_CACHE_BUILDER
     : _prefix(""), _verbose(verbose)
 #endif
 {
 }
 
-#if BUILDING_CACHE_BUILDER || BUILDING_UNIT_TESTS || BUILDING_CACHE_BUILDER_UNIT_TESTS
+#if BUILDING_CACHE_BUILDER
 Diagnostics::Diagnostics(const std::string& prefix, bool verbose)
     : _prefix(prefix),_verbose(verbose)
 {
@@ -89,7 +89,7 @@
         _buffer = _simple_salloc();
     _simple_vsprintf(_buffer, format, list);
 
-#if BUILDING_CACHE_BUILDER || BUILDING_UNIT_TESTS || BUILDING_CACHE_BUILDER_UNIT_TESTS
+#if BUILDING_CACHE_BUILDER
     if ( !_verbose )
         return;
 
@@ -141,7 +141,14 @@
     return (strstr(_simple_string(_buffer), subString) != nullptr);
 }
 
-#if BUILDING_CACHE_BUILDER || BUILDING_UNIT_TESTS || BUILDING_CACHE_BUILDER_UNIT_TESTS
+
+#if !BUILDING_CACHE_BUILDER
+const char* Diagnostics::errorMessage() const
+{
+    return _buffer ? _simple_string(_buffer) : "";
+}
+
+#else
 void Diagnostics::warning(const char* format, ...)
 {
     _SIMPLE_STRING tmp = _simple_salloc();
@@ -149,9 +156,13 @@
     va_start(list, format);
     _simple_vsprintf(tmp, format, list);
     va_end(list);
+#if BUILDING_CACHE_BUILDER
     dispatch_sync(sWarningQueue, ^{
         _warnings.insert(_simple_string(tmp));
     });
+#else
+    _warnings.insert(_simple_string(tmp));
+#endif
     _simple_sfree(tmp);
 }
 
@@ -202,30 +213,29 @@
 
 const std::set<std::string> Diagnostics::warnings() const
 {
+#if BUILDING_CACHE_BUILDER
     __block std::set<std::string> retval;
     dispatch_sync(sWarningQueue, ^{
         retval = _warnings;
     });
     return retval;
+#else
+    return _warnings;
+#endif
 }
 
 void Diagnostics::clearWarnings()
 {
+#if BUILDING_CACHE_BUILDER
     dispatch_sync(sWarningQueue, ^{
         _warnings.clear();
     });
-}
-
-#else
-
-const char* Diagnostics::errorMessage() const
-{
-    return _buffer ? _simple_string(_buffer) : "";
-}
-
-#endif
-
-#if BUILDING_CACHE_BUILDER || BUILDING_UNIT_TESTS || BUILDING_CACHE_BUILDER_UNIT_TESTS
+#else
+    _warnings.clear();
+#endif
+}
+
+#if BUILDING_CACHE_BUILDER
 void TimeRecorder::pushTimedSection() {
     openTimings.push_back(mach_absolute_time());
 }
@@ -249,8 +259,6 @@
         });
     }
 
-    free(output_string);
-
     openTimings.push_back(mach_absolute_time());
 }
 
@@ -273,6 +281,7 @@
 
     timings.clear();
 }
-
-#endif
-
+#endif
+
+#endif
+